Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webrtc-tester: implment --headless flag #350

Merged
merged 3 commits into from
Dec 6, 2023
Merged

webrtc-tester: implment --headless flag #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
903b47c
webrtc-tester: implment --headless flag
iameli Dec 5, 2023
798796d
Makefile: add make webrtc-load-tester
iameli Dec 5, 2023
46beaa2
Merge branch 'master' into eli/webrtc-tester-hacking
iameli Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ monitor:
api-transcoder:
go build -ldflags="$(ldflags)" cmd/api-transcoder/api-transcoder.go

.PHONY: webrtc-load-tester
webrtc-load-tester:
go build -ldflags="$(ldflags)" -o "$(GO_BUILD_DIR)" cmd/webrtc-load-tester/webrtc-load-tester.go

.PHONY: docker
docker:
docker build -f docker/Dockerfile -t livepeer/streamtester:latest --build-arg version=$(shell git describe --dirty) .
Expand Down
14 changes: 13 additions & 1 deletion cmd/webrtc-load-tester/roles/player.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ type playerArguments struct {
Simultaneous uint
PlayerStartInterval time.Duration
TestDuration time.Duration
Headless bool

ScreenshotFolderOS *url.URL
ScreenshotPeriod time.Duration
Expand All @@ -48,6 +49,7 @@ func Player() {
fs.DurationVar(&cliFlags.TestDuration, "duration", 1*time.Minute, "How long to run the test")
utils.URLVarFlag(fs, &cliFlags.ScreenshotFolderOS, "screenshot-folder-os", "", "Object Store URL for a folder where to save screenshots of the player. If unset, no screenshots will be taken")
fs.DurationVar(&cliFlags.ScreenshotPeriod, "screenshot-period", 1*time.Minute, "How often to take a screenshot of the player")
fs.BoolVar(&cliFlags.Headless, "headless", true, "Run Chrome in headless mode (no-GUI)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess Mist will never need to start this process right xD

})

if cliFlags.PlaybackID == "" && cliFlags.PlaybackURL == "" {
Expand All @@ -59,8 +61,18 @@ func Player() {

func runPlayerTest(args playerArguments) {
// Create a parent context to run a single browser instance
opts := chromedp.DefaultExecAllocatorOptions[:]
if !args.Headless {
opts = append(opts,
chromedp.Flag("headless", false),
chromedp.Flag("hide-scrollbars", false),
chromedp.Flag("mute-audio", false),
)
}
allocCtx, cancel := chromedp.NewExecAllocator(context.Background(), opts...)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
image

defer cancel()
ctx, cancel := chromedp.NewContext(
context.Background(),
allocCtx,
chromedp.WithBrowserOption(
chromedp.WithBrowserLogf(log.Printf),
chromedp.WithBrowserErrorf(log.Printf),
Expand Down
Loading