Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Redesign Class Info Page ✨ #118

Closed
wants to merge 6 commits into from
Closed

Conversation

AdrianAndersen
Copy link
Collaborator

@AdrianAndersen AdrianAndersen commented Feb 29, 2024

After a lot of design changes in the rest of the application, I feel like the design for the ClassInfo modal lags behind a lot. On mobile, there is always a scroll bar due to the large image, description, and class info.
This causes the action buttons (book / add to agenda) to be hidden from view when you open the modal, which is problematic.

Sooo, here is ✨a fresh new look✨ for the ClassInfo, slightly inspired by the BRP:

Future Class

Screenshot 2024-02-29 at 18 06 15

Planned Class

I introduced a default image for classes that don't have one. This just simplifies the design by not having to deal with non-image classes. Found this on Google and thought it was nice 🤠 In the future, we can consider having different default images for each category ✌️

Screenshot 2024-02-29 at 18 07 53

Booked Class

Screenshot 2024-02-29 at 18 08 13

Cancelled Class

Screenshot 2024-02-29 at 18 08 42

Dark Mode

Screenshot 2024-02-29 at 18 10 33

Mobile + ExpandableText

Some Sit Classes 👀 have reeeaaally long descriptions, so I opted to create a util that collapses the description by default if it is longer than a few lines of text.

Screen.Recording.2024-02-29.at.18.55.06.mov

@AdrianAndersen AdrianAndersen added the Feature A new feature label Feb 29, 2024
@AdrianAndersen AdrianAndersen self-assigned this Feb 29, 2024
@AdrianAndersen
Copy link
Collaborator Author

The final boss has been conquered 👑
image

@AdrianAndersen AdrianAndersen force-pushed the redesign-class-info branch 2 times, most recently from 94c2402 to ea08d57 Compare March 3, 2024 20:49
@AdrianAndersen
Copy link
Collaborator Author

The concept of having text on top of the image did not turn out as good as I hoped. Some work is ported over in #128

@AdrianAndersen AdrianAndersen deleted the redesign-class-info branch April 10, 2024 21:54
@AdrianAndersen AdrianAndersen removed the request for review from mathiazom April 12, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant