refactor(ClassInfo): DRY #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianAndersen
added
the
Refactor
AdrianAndersen
force-pushed
the
improve-class-info
branch
2 times, most recently
from
35fb990
to
14a5e2f
Compare
mathiazom
force-pushed
the
improve-class-info
branch
from
14a5e2f
to
d745219
Compare
mathiazom
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to salvage some work from the declined redesign PR.
Since the chip + text on image thing did not work out, I opted to just port over some of the DRY work I did on the component.
I opted to not bring expandable text, since it does not look that great with my April eyes. 👀
Supersedes #118