Stop depending on VPA mutating webhook for updating Pods #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanposhiho
force-pushed
the
tortoise-updator-vpa-removal
branch
from
a18a2c6
to
1e54024
Compare
sanposhiho
force-pushed
the
tortoise-updator-vpa-removal
branch
from
d70522e
to
2abd244
Compare
sanposhiho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We've been using VPA's Pod webhook to update Pods by the recommendation. That's because we can reduce the development cost of Pod mutating webhook in tortoise.
But, recently, for those features, we ended up creating the Pod mutating webhook.
GOMAXPROCSwhen changing the CPU limit #319GOMEMLIMITwhen changing the memory limit #320Then, rather than using VPA's Pod mutating webhook for something and using Tortoise's Pod mutating webhook for another thing, just using Tortoise's Pod mutating webhook is simpler and easier to maintain.
Which issue(s) this PR fixes:
Fixes #352
Special notes for your reviewer: