compare vversion in the schduler #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we can add some unit tests for this if they don't already exist. |
scanon
requested changes
Feb 23, 2024
scanon
requested changes
Mar 5, 2024
| if v1.major == v2.major and v1.minor == v2.minor: | ||
| return v1 == v2 | ||
|
|
||
| if getattr(v1, version_range) == getattr(v2, version_range): |
There was a problem hiding this comment.
This would just fetch the major minor or patch of the version right? It seems like this isn't quite right.
Do you have a test that is something like 1.1, 2.1, "minor"? I'm thinking this would match when it shouldn't.
| @@ -32,25 +32,29 @@ def get_mongo_db() -> MongoDatabase: | |||
| return _client[os.getenv("MONGO_DBNAME")] | |||
|
|
|||
|
|
|||
| def within_range(wf1: Workflow, wf2: Workflow, force=False) -> bool: | |||
| def within_range(wf1: Workflow, wf2: Workflow, version_range: str, force: bool = False) -> bool: | |||
There was a problem hiding this comment.
Maybe add a test and raise a ValueError if version_range isn't in the allowed options.
scanon
approved these changes
Mar 6, 2024
|
@scanon can we close this w/o merging since you've been fixing bugs in the version schedule comparisons? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconfigure how the scheduler considers version in the context of comparing workflows.