Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.8 #926

Merged
merged 76 commits into from
Apr 6, 2024
Merged

0.2.8 #926

merged 76 commits into from
Apr 6, 2024

Conversation

DominiqueMakowski
Copy link
Member

@DominiqueMakowski DominiqueMakowski commented Nov 6, 2023

Roadmap

RSP

  • Add rsp_segment() (similar to ppg_segment())
  • Add the cycle overlay plots to RSP
  • Streamline rsp_plot() (same as ppg_plot())

PPG

  • Detect PPG diastolic peaks? (between each peak and the next trough)
  • Add PPG amplitude calculation (reduction can be indicative of vasoconstriction in stress, cold)
  • Document peak-extraction methods (PPG)
  • add more PPG detectors (@peterhcharlton)
  • hrv_rsa(): Add method argument to compute only one RSA signal. Do something with warning that will be thrown when using bio_process() on signals < 32 sec where it will complain that the signal is too short to compute RSA with one of these methods.

Misc

setup.py Outdated
@@ -30,7 +28,7 @@ def find_version():
requirements = ["numpy", "pandas", "scipy", "scikit-learn>=1.0.0", "matplotlib"]

# Optional Dependencies (only needed / downloaded for testing purposes, for instance to test against some other packages)
setup_requirements = ["pytest-runner", "numpy"]
setup_requirements = ["pytest-runner", "numpy", "requests"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that alright @hoechenberger ?

Copy link

@hoechenberger hoechenberger Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, no, we need it in requirements (only) :)
Is my current understanding

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Attention: Patch coverage is 42.61603% with 136 lines in your changes are missing coverage. Please review.

Project coverage is 56.02%. Comparing base (3d004b4) to head (8e4ee00).

Files Patch % Lines
neurokit2/ecg/ecg_findpeaks.py 19.46% 91 Missing ⚠️
neurokit2/complexity/utils_complexity_symbolize.py 0.00% 9 Missing ⚠️
neurokit2/epochs/epochs_plot.py 10.00% 9 Missing ⚠️
neurokit2/misc/fig2img.py 18.18% 9 Missing ⚠️
neurokit2/data/read_xdf.py 0.00% 4 Missing ⚠️
neurokit2/ecg/ecg_clean.py 50.00% 4 Missing ⚠️
neurokit2/data/read_acqknowledge.py 81.81% 2 Missing ⚠️
neurokit2/eda/eda_analyze.py 33.33% 2 Missing ⚠️
neurokit2/emg/emg_activation.py 66.66% 2 Missing ⚠️
neurokit2/data/database.py 50.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   54.86%   56.02%   +1.15%     
==========================================
  Files         303      304       +1     
  Lines       14255    14367     +112     
==========================================
+ Hits         7821     8049     +228     
+ Misses       6434     6318     -116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 13, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 18, 2023
DominiqueMakowski and others added 24 commits March 3, 2024 09:00
[FIX] rr xcorr arange steps don't match
[Fix] adding sampling rate parameter to eda_intervalrelated method
…cate_channel_names

[Fix] read_acqknowledge now also imports duplicated channel names
I think it's a clearer demonstration of a possible usecase
[Feature] stim_events_find to retrieve multi-channel stimulus events
Copy link

codeclimate bot commented Apr 1, 2024

Code Climate has analyzed commit 4cd9ec4 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5

View more on Code Climate.

@DominiqueMakowski DominiqueMakowski merged commit e3f4469 into master Apr 6, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.