-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: hostile/clean #6966
base: master
Are you sure you want to change the base?
Conversation
@nf-core-bot fix linting |
Hi James, thanks for contributing this module and please let me know if I can assist.
As discussed in bede/hostile#46, Hostile is working as expected here, although I understand how confusion has arisen, and will look into clarifying the usage section and error message generated when a custom index is passed in an unexpected format. Thanks, |
I think I've got it for now thanks @bede ! I considered adding extra checks myself but it's always better for this to happen upstream in this context :) You can of course look at the code now and shout if you have any questiosn/suggestions for improvement |
NOT YET WORKING DUE TO ABUG IN THE TOOL ITSELFMISUNDERSTANDING OF DOCSNeed to either:- Specifically specify the aligner for SE data- Add error check if single end data that contents of index is actually minimaps2 compatibleCan be finished once bede/hostile#46 addressedI still haven't done the meta.yml yetNote: the two FASTQ files in the paired test are expected to be empty as all SARS-Cov2 reads aligned against the SARS-Cov2 reference genome (unsurprisingly ). Only a single read in the single-end data aligns for some reason.
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda