Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: hostile/clean #6966

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

New module: hostile/clean #6966

wants to merge 12 commits into from

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Nov 11, 2024

NOT YET WORKING DUE TO A BUG IN THE TOOL ITSELF MISUNDERSTANDING OF DOCS

Need to either:

- Specifically specify the aligner for SE data
- Add error check if single end data that contents of index is actually minimaps2 compatible

Can be finished once bede/hostile#46 addressed

I still haven't done the meta.yml yet

Note: the two FASTQ files in the paired test are expected to be empty as all SARS-Cov2 reads aligned against the SARS-Cov2 reference genome (unsurprisingly ). Only a single read in the single-end data aligns for some reason.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jfy133
Copy link
Member Author

jfy133 commented Nov 11, 2024

@nf-core-bot fix linting

@bede
Copy link

bede commented Nov 12, 2024

Hi James, thanks for contributing this module and please let me know if I can assist.

NOT YET WORKING DUE TO A BUG IN THE TOOL ITSELF

As discussed in bede/hostile#46, Hostile is working as expected here, although I understand how confusion has arisen, and will look into clarifying the usage section and error message generated when a custom index is passed in an unexpected format.

Thanks,
Bede

@jfy133 jfy133 marked this pull request as ready for review November 13, 2024 15:21
@jfy133
Copy link
Member Author

jfy133 commented Nov 13, 2024

Hi James, thanks for contributing this module and please let me know if I can assist.

NOT YET WORKING DUE TO A BUG IN THE TOOL ITSELF

As discussed in bede/hostile#46, Hostile is working as expected here, although I understand how confusion has arisen, and will look into clarifying the usage section and error message generated when a custom index is passed in an unexpected format.

Thanks, Bede

I think I've got it for now thanks @bede !

I considered adding extra checks myself but it's always better for this to happen upstream in this context :)

You can of course look at the code now and shout if you have any questiosn/suggestions for improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants