Remove R1CS_constraint_system from snark_intf #674
+12
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mimoo
reviewed
Nov 7, 2022
|
|
||
| val digest : t -> Md5.t | ||
|
|
||
| val get_public_input_size : t -> int Core_kernel.Set_once.t |
There was a problem hiding this comment.
arguably snarky should also be able to return the public input size right? I guess we never have a snarky type that stores the circuit and the constraint system, but I think it'd be a good idea to have these at some point
There was a problem hiding this comment.
oh okay, it's removed because it's actually unused. I see that this is not a very useful feature in general
There was a problem hiding this comment.
oh and there's still get_primary_input_size, we should be rename primary -> public
mimoo
approved these changes
Nov 7, 2022
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an unused function, and drops the
R1CS_constraint_systemmodule from theSnark_intf.*interfaces.