8344322: Improve capabilities of jpackage test lib to validate error output of jpackage #22207
Conversation
… strings from jpackage resource bundle. - test harness can better match values produced by @jdk.jpackage.test.Annotations.Parameters functions with test class ctors. - converted ErrorTest to use the new features
…rameter supplying method(s)
…not be cast to class java.lang.Comparable" error
…control on whet OS test method can be executed
…nment. Can control items annotated with @paremeter, @ParemeterSupplier, and @Paremeters and addition to those with @test annotation
…spaces (Use @=args instead of @Args)
…le belongs to some app launcher
… tests and make test case descriptions more helpful
… TestBuilder to TestMethodSupplier class
…erriding the current OS in tests
- Make TestBuilderConfig package private. - Fix "--mac-dmg-content" test case data in InOutPathTest
- Use new test annotations to improve InOutPathTest test
… in parameterized test
…ass when building the total set of all test descs
|
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
|
@alexeysemenyukoracle This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@alexeysemenyukoracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
@sashamatveev ptal |
Support using jpackage l10n keys instead of string values when examining jpackage error output.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22207/head:pull/22207$ git checkout pull/22207Update a local copy of the PR:
$ git checkout pull/22207$ git pull https://git.openjdk.org/jdk.git pull/22207/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22207View PR using the GUI difftool:
$ git pr show -t 22207Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22207.diff
Using Webrev
Link to Webrev Comment