Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8344322: Improve capabilities of jpackage test lib to validate error output of jpackage #22207

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

8344322: Improve capabilities of jpackage test lib to validate error output of jpackage #22207

wants to merge 37 commits into from
+217 −37

Commits on Nov 5, 2024

  1. - provide convenient way to verify jpackage output contains localized… 

    … strings from jpackage resource bundle.

- test harness can better match values produced by @jdk.jpackage.test.Annotations.Parameters functions with test class ctors.
- converted ErrorTest to use the new features
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    bf85eb3 View commit details
    Browse the repository at this point in the history

  2. Added @ParameterSupplier annotation to allow link test method with pa… 

    …rameter supplying method(s)
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    86e832d View commit details
    Browse the repository at this point in the history

  3. Fix "java.lang.ClassCastException: class java.lang.reflect.Method can… 

    …not be cast to class java.lang.Comparable" error
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9553295 View commit details
    Browse the repository at this point in the history

  4. Add @Test.includeOn() and @Test.excludeOn() annotation parameters to … 

    …control on whet OS test method can be executed
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a6b8107 View commit details
    Browse the repository at this point in the history

  5. More granular control on what test cases executed in the given enviro… 

    …nment. Can control items annotated with @paremeter, @ParemeterSupplier, and @Paremeters and addition to those with @test annotation
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    bf0abac View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into TKit.ParameterSupplier

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ed51e09 View commit details
    Browse the repository at this point in the history

  7. Support @command-file

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e8b8331 View commit details
    Browse the repository at this point in the history

  8. Can read command file without splitting lines into arguments at white… 

    …spaces (Use @=args instead of @Args)
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1dfd315 View commit details
    Browse the repository at this point in the history

  9. Bugfix

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1b5acd9 View commit details
    Browse the repository at this point in the history

  10. LinuxHelper.verifyDesktopFile() will verify that the given desktop fi… 

    …le belongs to some app launcher
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d09f8b5 View commit details
    Browse the repository at this point in the history

  11. Bugfix

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    01cef8f View commit details
    Browse the repository at this point in the history

  12. Added CannedFormattedString to simplify using string resources in the… 

    … tests and make test case descriptions more helpful
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9d0ad98 View commit details
    Browse the repository at this point in the history

  13. Bugfix for the case of empty arguments passed into foo(String ... args)

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d7ef6b9 View commit details
    Browse the repository at this point in the history

  14. Update copyright year

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ac8d913 View commit details
    Browse the repository at this point in the history

  15. Run blessed-modifier-order.sh script on changed files

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0825485 View commit details
    Browse the repository at this point in the history

  16. Trailing whitespaces removed

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    25a26db View commit details
    Browse the repository at this point in the history

  17. Bugfix

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4d87507 View commit details
    Browse the repository at this point in the history

  18. Move code handling annotations and other reflection-related work from… 

    … TestBuilder to TestMethodSupplier class
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e754e51 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Add unit testing for the new annotations

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    92eacaa View commit details
    Browse the repository at this point in the history

  2. Add unit tests for ifOS and ifNotOS annotation properties. Support ov… 

    …erriding the current OS in tests
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1591c58 View commit details
    Browse the repository at this point in the history

  3. Test summary reworded

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0b7101d View commit details
    Browse the repository at this point in the history

  4. - Minor cleanup. 

     - Make TestBuilderConfig package private.
 - Fix "--mac-dmg-content" test case data in InOutPathTest
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    01bffbd View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Merge branch 'master' into TKit.ParameterSupplier

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    7bf7597 View commit details
    Browse the repository at this point in the history

  2. - add test coverage to @Parameters.ifOS and @Parameters.ifNotOS. 

    - Use new test annotations to improve InOutPathTest test
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f939b19 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Merge branch 'master' into JDK-8343876

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    f222964 View commit details
    Browse the repository at this point in the history

  2. Use Comparator

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    b13e36d View commit details
    Browse the repository at this point in the history

  3. Full test class name in test case description

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    2630249 View commit details
    Browse the repository at this point in the history

  4. Add test case to validate static test case will be executed only once… 

    … in parameterized test
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    ea454ac View commit details
    Browse the repository at this point in the history

  5. Don't create intermediate set of expected test descs for very test cl… 

    …ass when building the total set of all test descs
    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    767a8a7 View commit details
    Browse the repository at this point in the history

  6. Don't run static test methods with test instances

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    998d993 View commit details
    Browse the repository at this point in the history

  7. Use "validate" instead of "verify" for the new API

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    4c6d78e View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Merge branch 'master' into JDK-8343876

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    27f2447 View commit details
    Browse the repository at this point in the history

  2. Minor cleanup

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1c7e059 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Fix finding in the review

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    66c1583 View commit details
    Browse the repository at this point in the history

  2. Remove redundant "method.setAccessible(true);" calls

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ba89798 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Merge branch 'master' into JDK-8343876.JPackageErrorOutputVerify

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    916e29f View commit details
    Browse the repository at this point in the history

  2. Comment reworded

    @alexeysemenyukoracle
    alexeysemenyukoracle committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    521e1fd View commit details
    Browse the repository at this point in the history