PIN-5661 - Create consumer delegation #1197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecamellini
force-pushed
the
PIN-5661-post-consumer-delegations
branch
from
a257b22
to
c4583fe
Compare
ecamellini
changed the base branch from
main
to
feature/Incaricato-tenant_PIN-5653
Base automatically changed from
feature/Incaricato-tenant_PIN-5653
to
feature/incaricato
November 12, 2024 15:22
ecamellini
force-pushed
the
PIN-5661-post-consumer-delegations
branch
from
1707064
to
c20adc3
Compare
AsterITA
reviewed
Nov 14, 2024
| @@ -118,19 +118,20 @@ paths: | |||
| schema: | |||
| $ref: "#/components/schemas/Problem" | |||
| /delegations/{delegationId}: | |||
| parameters: | |||
There was a problem hiding this comment.
Shouldn't we add the CorrelationIdHeader too?
There was a problem hiding this comment.
Yes, we should! Apparently, it's missing everywhere in this spec, I added it in 2507337
|
After the review and merge, maybe it's worth porting some of these changes to the develop branch (e.g., fixes to tests, API specs, etc.) |
ecamellini
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
develop?Tests
Automated tests pass ✅
Manual tests
Success ✅
Readmodel insert works ✅
Smoke testing some errors