Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegation process improvements in errors, tests, API spec #1209

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

ecamellini
Copy link
Collaborator

@ecamellini ecamellini commented Nov 18, 2024

Porting to develop some improvements I made in #1197 because not strictly related to the feature "Incaricato".
Tests pass ✅

}
};

export const assertTenantExists = async (
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused

@ecamellini ecamellini marked this pull request as ready for review November 18, 2024 11:44
@ecamellini ecamellini changed the title Delegation process tests & API improvements Delegation process tests & API spec improvements Nov 18, 2024
@ecamellini ecamellini changed the title Delegation process tests & API spec improvements Delegation process improvements in errors, tests, API spec Nov 18, 2024
Copy link
Contributor

@Carminepo2 Carminepo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you, Eric!

@ecamellini
Copy link
Collaborator Author

@Carminepo2 asking review again because after the weekly I refactored the IPA check a little bit, let me know if it makes sense to you :)

Copy link
Collaborator

@MalpenZibo MalpenZibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants