Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate the one-page tutorial in your language! #267

Open
Lucas-C opened this issue Oct 25, 2021 · 44 comments · Fixed by #579 or #738
Open

Translate the one-page tutorial in your language! #267

Lucas-C opened this issue Oct 25, 2021 · 44 comments · Fixed by #579 or #738

Comments

@Lucas-C
Copy link
Member

Lucas-C commented Oct 25, 2021

The tutorial is a simple Markdown document:

It is currently available in several languages, listed in the README and the documentation index page.

PRs are very welcome to add new translations!
PR authors will be added to the contributors list & map.


Guidelines:

  • open a Pull Request that creates or modifies the corresponding docs/Tutorial-xy.md file, taking inspiration from docs/Tutorial.md (where xy is the ISO_639-1 language code)
  • if you created a new file, add a reference to it in docs/index.md, mkdocs.yml, README.md and CHANGELOG.md, taking inspiration from the references to existing translated tutorials
@Mridulbirla13
Copy link

Mridulbirla13 commented Oct 26, 2021

Hey, I want to work on this issue. I will translate this tutorial in Hindi(हिंदी)

@Lucas-C
Copy link
Member Author

Lucas-C commented Oct 26, 2021

Awesome! Thank you @Mridulbirla13 😊

If you need any help, on fpdf2 or how to submit a PR, ask you your questions here!

@Tititesouris
Copy link

Hi, I can take care of the French translation if you want :)

@Lucas-C
Copy link
Member Author

Lucas-C commented Oct 26, 2021

@Tititesouris : chouette !
Je procrastine à faire la trad depuis des mois ^^
Avec plaisir !

@digidigital
Copy link

I can provide a German translation.

@Lucas-C
Copy link
Member Author

Lucas-C commented Oct 27, 2021

Great! Go ahead 😉

@Tititesouris
Copy link

Hey @Lucas-C, vu la quantité de travail, mon temps limité et le fait que Hacktoberfest arrive bientôt à son terme, est-ce que ça te dérange si je te fais une première PR avec le tuto 1 (tu peux du coup déjà me faire un retour sur la qualité), et une autre PR d'ici le 30 avec au moins les tutos 2 & 3 ?
Dans tous les cas je te traduis l'entièreté d'ici la mi-novembre 😉

@Lucas-C
Copy link
Member Author

Lucas-C commented Oct 28, 2021

Aucun problème, fais ça au rythme que tu veux !

@yellkrishna
Copy link

The tutorial is a simple Markdown document:

It is currently available in English, Français, Deutsch, Hindi, Italian, Portugese, Russian & Spanish.

PRs are very welcome to add new translations!

Hey! I can provide a Telugu translation for this.

@Lucas-C
Copy link
Member Author

Lucas-C commented Dec 7, 2021

@yellkrishna That would be wonderful!
Thank you for volunteering 🙏❤️

@Lucas-C Lucas-C pinned this issue Jan 28, 2022
@bcronald
Copy link

Hi! I want to translate in Tamil please.

@Lucas-C
Copy link
Member Author

Lucas-C commented Apr 18, 2022

Hi and welcome @bcronald !
That would be great 😊
Do you need guidance on how to proceed, or do you already know how to submit a PR?

@Lucas-C
Copy link
Member Author

Lucas-C commented Apr 18, 2022

By the way @yellkrishna & @bcronald: have you checked that fpdf2 can render text in those languages?
I'm curious because we have already faced limitations with Hindi: #365

@bcronald
Copy link

Hi and welcome @bcronald ! That would be great blush Do you need guidance on how to proceed, or do you already know how to submit a PR?

Thanks. Yes please, guidance would be nice. Sorry for the late reply.

@bcronald
Copy link

By the way @yellkrishna & @bcronald: have you checked that fpdf2 can render text in those languages? I'm curious because we have already faced limitations with Hindi: #365

No, not yet checked in Tamil. I will do that and post result.

@bcronald
Copy link

By the way @yellkrishna & @bcronald: have you checked that fpdf2 can render text in those languages? I'm curious because we have already faced limitations with Hindi: #365

No, not yet checked in Tamil. I will do that and post result.

Tamil is not being rendered correctly.

Code:
from fpdf import FPDF

pdf = FPDF()
pdf.add_page()
pdf.add_font('lohit-taml', fname='/usr/share/fonts/truetype/lohit-tamil/Lohit-Tamil.ttf')
pdf.set_font('lohit-taml', size=18)
pdf.write(8, u'யாதும் ஊரே யாவரும் கேளிர்')
pdf.output("fpdf2_tamil_test.pdf")

Attached the resulting pdf below:
fpdf2_tamil_test.pdf

@Lucas-C
Copy link
Member Author

Lucas-C commented Apr 21, 2022

Tamil is not being rendered correctly.

It's a pity 😔 Thanks for testing @bcronald.
I don't know Tamil: is the problem with ligatures, like for Hindi text, or is there a different issue here?

@bcronald
Copy link

bcronald commented Apr 23, 2022

is the problem with ligatures, like for Hindi text, or is there a different issue here?

Yes, it is the same problem as here global-healthy-liveable-cities/global_scorecards#7
When the text is selected and copied from the pdf and pasted into text editor (I am on Ubuntu 20.04) it apperars correctly, wheras in the pdf, the components of a complex character are either not arranged in the correct sequence or not attached together with main character.

@sokratisvas
Copy link

Hi, I can provide a Greek translation.

@Lucas-C
Copy link
Member Author

Lucas-C commented Aug 9, 2022

Hi and welcome @bcronald ! That would be great blush Do you need guidance on how to proceed, or do you already know how to submit a PR?

Thanks. Yes please, guidance would be nice. Sorry for the late reply.

I suggest to read the following documentation on how to submit a contribution:
https://opensource.guide/how-to-contribute/#how-to-submit-a-contribution

Once you will be familiar with the basic concepts of git & GitHub,
you can copy the file docs/Tutorial.md in a file docs/Tutorial-ta.md and perform the translation. Then submit a Pull Request containing this file.

Hi, I can provide a Greek translation.

That would be awesome @sokratisvas , great!

Do you need any more information or guidance?

@Lucas-C
Copy link
Member Author

Lucas-C commented Dec 29, 2022

Re-opening this: I just now realize that I closed the issue in October 🤭😅

We would still welcome new translations though!

@Lucas-C Lucas-C reopened this Dec 29, 2022
@Bubbu0129
Copy link

Need Simplified Chinese translation? I think I can get the main parts translated, but maybe not every page of the doc.

@Lucas-C
Copy link
Member Author

Lucas-C commented Jan 14, 2023

Yes, such translation of the tutorial would be welcome @Bubbu0129!

Even if you only translate one or two of the 6 sections of the tutorial, a PR would be welcome as a starting point!

@ssavi-ict
Copy link

Hello, @Lucas-C I would like to work on Bengali Translation. Can I do that?
If yes then a Quick Question - I need to translate this Tutorial.md file. Am I right?

@Lucas-C
Copy link
Member Author

Lucas-C commented Mar 13, 2023

Hello, @Lucas-C I would like to work on Bengali Translation. Can I do that?

Wonderful! Yes, please do so!

then a Quick Question - I need to translate this Tutorial.md file. Am I right?

Exactly 😊
You can take inspiration from the previous PRs,
like this one that introduced a Russian translation: #283

@ssavi-ict ssavi-ict mentioned this issue Mar 17, 2023
5 tasks
@Lucas-C
Copy link
Member Author

Lucas-C commented Mar 27, 2023

Note to all translators: with the introduction of the new FPDF.table() method,
the section 5 of the tutorial is now obsolote and was removed from all tutorials.

Contributions are welcome to translate the new section 5 (https://pyfpdf.github.io/fpdf2/Tutorial.html#tuto-5-creating-tables) from English to one of those languages:

@ssavi-ict ssavi-ict mentioned this issue Mar 27, 2023
5 tasks
@Lucas-C Lucas-C reopened this Apr 3, 2023
@ssavi-ict ssavi-ict mentioned this issue Apr 12, 2023
5 tasks
@kuth-chi
Copy link

kuth-chi commented Jun 2, 2023

The tutorial is a simple Markdown document:

It is currently available in several languages, listed in the README and the documentation index page.

PRs are very welcome to add new translations! PR authors will be added to the contributors list & map.

Guidelines:

  • open a Pull Request that creates or modifies the corresponding docs/Tutorial-xy.md file, taking inspiration from docs/Tutorial.md (where xy is the ISO_639-1 language code)
  • if you created a new file, add a reference to it in docs/index.md, mkdocs.yml, README.md and CHANGELOG.md, taking inspiration from the references to existing translated tutorials

I have committed a file in FPDF/docs/Tutorial.km.md is Khmer language tutorial, but today still unavailable . How to check next flow?

@Lucas-C
Copy link
Member Author

Lucas-C commented Jun 2, 2023

I have committed a file in FPDF/docs/Tutorial.km.md is Khmer language tutorial, but today still unavailable . How to check next flow?

Hi @kuth-chi!

I see that you have added a commit on branch patch-1 of your fork there:
https://github.com/kuth-chi/fpdf2/tree/patch-1

What you need now is to open a Pull Request againt this repository, https://github.com/PyFPDF/fpdf2,
so that I can then review your contribution, and merge it.

This guide explains how to submit a Pull Request in details: https://opensource.guide/how-to-contribute/#opening-a-pull-request

@kuth-chi
Copy link

kuth-chi commented Jun 2, 2023

Thank you ,

@gmischler
Copy link
Collaborator

gmischler commented Oct 23, 2023

Note to all translators:

Contributions are welcome to translate the new sections 4 and 5 from English or German to one of those languages:
Calling out to previous translators of each language! (Anyone else is of course also invited.)

@TzviGreenfeld
Copy link

hey @gmischler, I've updated the Hebrew tutorial at #978.
just not sure if this requires a changelog update or anything else. let me know please

@gmischler
Copy link
Collaborator

hey @gmischler, I've updated the Hebrew tutorial at #978.
just not sure if this requires a changelog update or anything else. let me know please

Cool, thanks!
I only see changelog entries for full new tutorial translations, so I guess it's not required here...

@Polderrider
Copy link

Leave the Dutch to me. Not that they need it as Dutch IT dudes English is more than sufficient! But this will be only my second contribution ever, so it's a nice starter for using git. It will also help improve my Dutch which i am learning. Don't worry i will have a native speaker cast an eye over it before i publish

@gmischler
Copy link
Collaborator

Leave the Dutch to me.

Thanks for the offer, @Polderrider!
Just go right ahead and create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet