Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hebrew tutorial translation section 4 and 5 #978

Merged

Conversation

TzviGreenfeld
Copy link

updated sections 4 and 5 of the hebrew tutorial, as requested in
#267 (comment)
e.g. Fixes #0

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@gmischler
Copy link
Collaborator

Thanks a lot, @TzviGreenfeld !

@gmischler
Copy link
Collaborator

@TzviGreenfeld, I'm unable merge it while it's still a draft.
Can you remove the draft designation please?

@TzviGreenfeld TzviGreenfeld reopened this Oct 23, 2023
@TzviGreenfeld TzviGreenfeld marked this pull request as ready for review October 23, 2023 10:51
@gmischler gmischler merged commit 99e4d6d into py-pdf:master Oct 23, 2023
18 of 20 checks passed
@Lucas-C
Copy link
Member

Lucas-C commented Nov 2, 2023

@allcontributors please add @TzviGreenfeld for translation

Copy link

@Lucas-C

I've put up a pull request to add @TzviGreenfeld! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants