Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Russian tutorial #272

Closed
wants to merge 10 commits into from
Closed

docs: add Russian tutorial #272

wants to merge 10 commits into from

Conversation

AABur
Copy link

@AABur AABur commented Oct 26, 2021

re: #267

@AABur AABur requested a review from Lucas-C as a code owner October 26, 2021 14:13
@Lucas-C
Copy link
Member

Lucas-C commented Oct 26, 2021

Nice, thanks ! I'll review this today or tomorrow

Also, if you rebase on the latest commit on master,
you should not be bothered by the build_contributors_html_page.py script hanging anymore

Copy link
Member

@Lucas-C Lucas-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Could you also add links to your tutorial in the README.md, CHANGELOG.md & docs/index.md pages please?
Once your branch is rebased on master I'll merge this very soon

@Lucas-C
Copy link
Member

Lucas-C commented Oct 27, 2021

Seems like the rebase did not go well...
There shouldn't be 28 files changed as part of this PR.
Sadly I cannot merge it in its current state.

If your struggling with this, you can always close this PR and open a new one
based on the current state of this GitHub repo.
Things should be simpler this way.

@AABur
Copy link
Author

AABur commented Oct 28, 2021

Indeed I messed up with the rebase. Better make a new PR

@Lucas-C
Copy link
Member

Lucas-C commented Oct 29, 2021

Would you like this PR be merged during hacktoberfest ?
I will be less available this week-end to review PRs, but I'll try to check things here on Sunday.

@AABur
Copy link
Author

AABur commented Oct 29, 2021

Would you like this PR be merged during hacktoberfest ? I will be less available this week-end to review PRs, but I'll try to check things here on Sunday.

It will be great to catch up on hacktoberfest. I will make my changes tonight in the new PR

@AABur
Copy link
Author

AABur commented Oct 29, 2021

redo at #283

@AABur AABur closed this Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants