chore(quinn-udp): tweak log levels #2048
Open
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
force-pushed
the
chore/less-error-logs
branch
from
861c63b
to
5bf9105
Compare
It is common to set up automated error reporting based on `ERROR` and potentially also `WARN` logs. Whilst GSO being unsupported is certainly something worthwhile logging, the `ERROR` log level seems a bit excessive and leads to unactionable errors reports. The system can still operate with `max_gso_segments == 1`. As such, this codepath "merely" indicates a state change in the system but not a fatal error. As such, logging this on INFO level seems more appropriate.
Logging AND returning errors is considered an anti-pattern because it leads to duplicate logs.
thomaseizinger
force-pushed
the
chore/less-error-logs
branch
from
5bf9105
to
6e1760e
Compare
djc
approved these changes
Nov 18, 2024
|
This makes sense to me, thanks! |
|
The CI failure seems like a fluke to me? Could you rerun those perhaps? |
|
This doesn't look like a fluke: error: unused import: `error`
--> quinn-udp\src\windows.rs:17:18
|
17 | log::{debug, error},
| ^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]` |
Ah didn't see that in the output, makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to remove the two
ERRORlogs that we currently have inquinn-udp. Rationale is explained separately in each commit message.