Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(quinn-udp): tweak log levels #2048

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Nov 18, 2024

  1. Log GSO halt on info

    It is common to set up automated error reporting based on `ERROR` and
    potentially also `WARN` logs. Whilst GSO being unsupported is certainly
    something worthwhile logging, the `ERROR` log level seems a bit
    excessive and leads to unactionable errors reports.
    
    The system can still operate with `max_gso_segments == 1`. As such, this
    codepath "merely" indicates a state change in the system but not a fatal
    error. As such, logging this on INFO level seems more appropriate.
    thomaseizinger committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    6555636 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Don't log and return

    Logging AND returning errors is considered an anti-pattern because it
    leads to duplicate logs.
    thomaseizinger committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    881b534 View commit details
    Browse the repository at this point in the history