Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nats): align offset and property fields between NATS and others for better ux and dx #18732

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

stdrc
Copy link
Contributor

@stdrc stdrc commented Sep 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Seems we now prefer the following style of connector properties:

scan.startup.mode='timestamp',
scan.startup.timestamp.millis='123456'

This PR refines the NATS source connector to align with this style.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

risingwavelabs/risingwave-docs#2643

Copy link
Contributor Author

stdrc commented Sep 26, 2024

@stdrc stdrc changed the title align offset and property fields between nats and others for better ux and dx fix: align offset and property fields between nats and others for better ux and dx Sep 26, 2024
@stdrc stdrc changed the title fix: align offset and property fields between nats and others for better ux and dx fix: align offset and property fields between NATS and others for better ux and dx Sep 26, 2024
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Sep 26, 2024
@stdrc stdrc marked this pull request as ready for review September 26, 2024 07:47
@stdrc stdrc changed the title fix: align offset and property fields between NATS and others for better ux and dx fix(nats): align offset and property fields between NATS and others for better ux and dx Sep 26, 2024
Copy link
Member

@yufansong yufansong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stdrc stdrc added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit d6f8ca2 Sep 27, 2024
30 of 31 checks passed
@stdrc stdrc deleted the rc/refine-nats-source branch September 27, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants