Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nats): align the semantics of scan.startup.mode=latest of NATS with others #18733

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

stdrc
Copy link
Contributor

@stdrc stdrc commented Sep 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

For source connector offset XxxOffset::Latest, we always mean to start from the next future record after the most recently available one. This applies for Kafka, Kinesis and Pulsar. This PR fixes the semantics for NATS.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor Author

stdrc commented Sep 26, 2024

@stdrc stdrc changed the title align the semantics of scan.startup.mode=latest of nats with others fix(nats): align the semantics of scan.startup.mode=latest of NATS with others Sep 26, 2024
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Sep 26, 2024
@stdrc stdrc marked this pull request as ready for review September 26, 2024 07:49
@stdrc stdrc force-pushed the rc/nats-source-latest-semantics branch from 8385894 to 29956ac Compare September 26, 2024 08:49
Copy link
Member

@yufansong yufansong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe we need to note this change in our doc and release note?
https://docs.rs/async-nats/latest/async_nats/jetstream/consumer/enum.DeliverPolicy.html#variant.Last

@stdrc
Copy link
Contributor Author

stdrc commented Sep 27, 2024

maybe we need to note this change in our doc and release note?

Yes, I'll note this in the docs.

Base automatically changed from rc/refine-nats-source to main September 27, 2024 04:36
@stdrc stdrc force-pushed the rc/nats-source-latest-semantics branch from b915fbe to 068e65d Compare September 27, 2024 07:04
@stdrc stdrc added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 056ccfb Sep 27, 2024
31 of 32 checks passed
@stdrc stdrc deleted the rc/nats-source-latest-semantics branch September 27, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants