-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nats): align the semantics of scan.startup.mode=latest
of NATS with others
#18733
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
scan.startup.mode=latest
of NATS with others
8385894
to
29956ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe we need to note this change in our doc and release note?
https://docs.rs/async-nats/latest/async_nats/jetstream/consumer/enum.DeliverPolicy.html#variant.Last
791dd08
to
c885844
Compare
29956ac
to
b915fbe
Compare
Yes, I'll note this in the docs. |
b915fbe
to
068e65d
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
For source connector offset
XxxOffset::Latest
, we always mean to start from the next future record after the most recently available one. This applies for Kafka, Kinesis and Pulsar. This PR fixes the semantics for NATS.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.