Add motoman resources (#378 rebased) #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make robots use materials from that package so they do not conflict when using multiple arms.
And remove macro-local definitions of colors and materials from .xacro files.
Both not necessarily 'official' in any way, but used in (old) xacro:macros.
|
Merging as I've reviewed the original #378 and CI is green. |
This was referenced May 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I did not want to risk pushing to a company branch (in #378), I've rebased and added a few additional commits.
Attribution retained where appropriate.
I'll rebase follow-up PRs (#395, #396 and #397) as well.