Switch nav2_waypoint_follower to modern CMake idioms. #4648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Change nav2_waypoint_follower to modern CMake idioms:
Note well that this will fail to compile until cra-ros-pkg/robot_localization#895 is merged, released, and synced into Rolling.
Description of documentation updates required from your changes
None needed.
Future work that may be required in bullet points
This is the last of the series to convert Navigation2 to modern CMake idioms. One suggestion I might make is to attempt to release the
main
branch of Navigation2 into Rolling to make sure we've gotten all of the dependencies correct. Short of that, this should be the end of this particular series.For Maintainers: