Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch nav2_waypoint_follower to modern CMake idioms. #4648

Conversation

clalancette
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses Follow-up to #4357
Primary OS tested on Ubuntu 24.04
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Change nav2_waypoint_follower to modern CMake idioms:

  1. Switch from ament_target_dependencies to target_link_libraries.
  2. Export a CMake target so downstream packages can use it.
  3. Push the include directories down one level, which has been best practice since Humble.

Note well that this will fail to compile until cra-ros-pkg/robot_localization#895 is merged, released, and synced into Rolling.

Description of documentation updates required from your changes

None needed.


Future work that may be required in bullet points

This is the last of the series to convert Navigation2 to modern CMake idioms. One suggestion I might make is to attempt to release the main branch of Navigation2 into Rolling to make sure we've gotten all of the dependencies correct. Short of that, this should be the end of this particular series.

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link
Contributor

mergify bot commented Aug 24, 2024

@clalancette, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

Copy link
Contributor

mergify bot commented Sep 9, 2024

@clalancette, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

@SteveMacenski
Copy link
Member

Retriggering CI, is this ready to go now with binary updates?

@clalancette
Copy link
Contributor Author

Retriggering CI, is this ready to go now with binary updates?

Yeah, I think this should be ready, though CI failed to upload coverage results.

@SteveMacenski
Copy link
Member

That's just a rebase issue, since your branch doesn't include that file. LGTM!

@SteveMacenski SteveMacenski merged commit 406a2f5 into ros-navigation:main Oct 2, 2024
9 of 10 checks passed
@clalancette clalancette deleted the clalancette/main-nav2-waypoint-follower branch October 3, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants