Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color space output for rgb/hsl/hsv color filters #61

Open
wants to merge 6 commits into
base: indigo
Choose a base branch
from

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Apr 21, 2017

Enable to publish color space during filtering
@tongtybj, @chibi314 could you check this node with your example?

rgb space
rgb

hls space
hls

hsv space
hsv

roslaunch opencv_apps hsv_color_filter.launch image:=/camera/rgb/image_color

Discussions

  • we publish color space by PointCloud2, is it ok? if we use PointCloud2, we need to set frame_id (currently it is map) and define scales (1 for now)
  • Should we publish threshold? One idea is to publish threshold planes, other is publish point within threshold with colored and publish outlier points with gray scale

==

input image
input_color

rgb space
screenshot from 2017-04-21 18 02 33

hls space
screenshot from 2017-04-21 21 26 32

hsv space
screenshot from 2017-04-21 21 27 53

https://gist.github.com/k-okada/5c7531cecc5c04abff0674afe35eba06

@tongtybj
Copy link
Contributor

I tested the data in 柏 while flying towards to target tree.

RGB space
rgb_filter

HLS spce
hls_filter

HSV space
hsv_filter-iloveimg-compressed

I am not familiar with the format of point cloud.
And I prefer threshold plane, because we can see the change directly while tuning the filtering parameters from cfg

@k-okada
Copy link
Contributor Author

k-okada commented Apr 23, 2017

very nice example, how about 233500f, this outputs with gray if the point is not within the threshold

screenshot from 2017-04-23 18 21 49

@tongtybj
Copy link
Contributor

I tried with the same rosbag. LVGTM!

RGB space
rgb_filter_new2

HLS space
hls_filter_new2

HSV space
hsv_filter_new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants