Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Avoid throwing errors for shared input/output IDs #4101

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: Avoid throwing errors for shared input/output IDs #4101

wants to merge 19 commits into from
+485 −293

Commits on Jul 15, 2024

  1. refactor: Factor out message display from error handler

    @gadenbuie
    gadenbuie committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ad4a482 View commit details
    Browse the repository at this point in the history

  2. feat: Add custom event for sending a client message

    @gadenbuie
    gadenbuie committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4cd7e72 View commit details
    Browse the repository at this point in the history

  3. feat: Report binding validity problem via event instead of throwing e… 

    …rror
    @gadenbuie
    gadenbuie committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    04a6d9d View commit details
    Browse the repository at this point in the history

  4. feat: Don't need to hide shared input/output message 

    Now that it's not an error, it's safe to report
    @gadenbuie
    gadenbuie committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    2c028df View commit details
    Browse the repository at this point in the history

  5. refactor: Move inDevMode() logic into error console

    @gadenbuie
    gadenbuie committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    006df8b View commit details
    Browse the repository at this point in the history

  6. refactor: Rename .error --> .event

    @gadenbuie
    gadenbuie committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b7f26ac View commit details
    Browse the repository at this point in the history

  7. devtools::document() (GitHub Actions)

    @gadenbuie
    gadenbuie committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    bd62b28 View commit details
    Browse the repository at this point in the history

  8. yarn build (GitHub Actions)

    @gadenbuie
    gadenbuie committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9cfc437 View commit details
    Browse the repository at this point in the history

  9. feat: Do throw error for duplicated input or output IDs

    @gadenbuie
    gadenbuie committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    651d9a1 View commit details
    Browse the repository at this point in the history

  10. feat: wrap client error message 

    It's otherwise hard to tell that the error is scrollable
Plus the scrolling is over the whole message rather than the part that overflows
    @gadenbuie
    gadenbuie committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    77d1153 View commit details
    Browse the repository at this point in the history

  11. yarn build (GitHub Actions)

    @gadenbuie
    gadenbuie committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    2db9ce8 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Merge branch 'main' into feat/client-message-event

    @gadenbuie
    gadenbuie committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    236a9e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. feat: always send client console messages to browser console as well

    @gadenbuie
    gadenbuie committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    eb513a7 View commit details
    Browse the repository at this point in the history

  2. chore: throw if shiny:client-message receives an event that isn't C… 

    …ustomEvent
    @gadenbuie
    gadenbuie committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c8bc385 View commit details
    Browse the repository at this point in the history

  3. chore: apply suggestions from code review

    @gadenbuie
    gadenbuie committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2d47c2f View commit details
    Browse the repository at this point in the history

  4. Merge 'origin/main' into branch feat/client-message-event

    @gadenbuie
    gadenbuie committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d57045c View commit details
    Browse the repository at this point in the history

  5. yarn build (GitHub Actions)

    @gadenbuie
    gadenbuie committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a6b4452 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. feat: Handle status in showShinyClientMessage() 

    * Renamed `showMessageInClientConsole()` to `showShinyClientMessage()` to improve clarity
* Added `status` argument to `showShinyClientMessage()` to allow for different message types
    @gadenbuie
    gadenbuie committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7963436 View commit details
    Browse the repository at this point in the history

  2. docs: Add NEWS items

    @gadenbuie
    gadenbuie committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    820a8a9 View commit details
    Browse the repository at this point in the history