Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Avoid throwing errors for shared input/output IDs #4101

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# shiny (development version)

## Breaking changes

* Duplicated IDs (used more than once for an input or output) now throw an error in the browser, which appears as a message in Shiny's Client Console when `devmode()` is enabled or as a message in the browser console if not. (#4101)

Prior to Shiny v1.8.1, duplicated output IDs (but not duplicated input IDs) threw an error on app startup. After v1.8.1 neither resulted in an error, but a message would be shown in the Client Console when `devmode()` was enabled. The change in this version restores the previous behavior and extends it to input IDs as well.

## New features and improvements

* Small improvements to the default pulse busy indicator to better blend with any background. It's also now slightly smaller by default. (#4122)
Expand All @@ -14,6 +20,8 @@

* `dateInput` and `dateRangeInput` no longer send immediate updates to the server when the user is typing a date input. Instead, it waits until the user presses Enter or clicks out of the field to send the update, avoiding spurious and incorrect date values. Note that an update is still sent immediately when the field is cleared. (#3664)

* Shared input and output IDs -- e.g. using `"debug"` for both a `textInput()` and `verbatimTextOutput()` -- now results in a console warning message, but not an error, that is also shown in the Client Console when `devmode()` is enabled. (#4101)

# shiny 1.9.1

## Bug fixes
Expand Down
Loading
Loading