github/workflow: remove the confusing comment #2227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyh
approved these changes
May 8, 2024
|
I'll merge this patch, but it gave me an opportunity to see the CI build in action. I see at the top of the page in the "checks" tab only 12 checks. It seems to list only the 12 regular combinations - and not the two extra checks you wanted to add for dpdk and modules. Are you sure those are running? |
tchaikov
force-pushed
the
github-workflow-comments
branch
3 times, most recently
from
06a6563
to
9a19de7
Compare
before this change, we * override the combination of <clang++,23,release> by adding settings to build with dpdk enabled, * override the combination of <clang++,23,debug> by adding settings to build with C++20 moduels enabled. but what we intended was to add two additional builds. so, in this change, we preserve the existing combinations of <clang++,23,release> and <clang++,23,debug> by includeing all the combinations explicitly, and add the builds with dpdk and C++20 modules. also the matrix does not allows one to add extra settings without overriding an existing combination. see also https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs also remove the confusing comment based on the feedback of reviewer, > the phrase "only build this combination when dpdk is enable" confusing > - the phrase "in addition to the above" says the opposite, that we did > build this combination without dpdk but now we'll build it again with > dpdk. Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
github-workflow-comments
branch
from
9a19de7
to
8f388df
Compare
nyh
approved these changes
May 8, 2024
|
there are still 12 builds. i need to find anther way to fix the matrix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the feedback of reviewer,