Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflow: remove the confusing comment #2227

Closed
wants to merge 1 commit into from

Commits on May 8, 2024

  1. github/workflow: do not override <clang++,23,release>

    before this change, we
    
    * override the combination of <clang++,23,release>
      by adding settings to build with dpdk enabled,
    * override the combination of <clang++,23,debug>
      by adding settings to build with C++20 moduels
      enabled.
    
    but what we intended was to add two additional
    builds.
    
    so, in this change, we preserve the existing
    combinations of <clang++,23,release> and
    <clang++,23,debug> by includeing all the
    combinations explicitly, and add the builds
    with dpdk and C++20 modules. also the matrix
    does not allows one to add extra settings without
    overriding an existing combination.
    see also https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs
    
    also remove the confusing comment
    
    based on the feedback of reviewer,
    
    > the phrase "only build this combination when dpdk is enable" confusing
    > - the phrase "in addition to the above" says the opposite, that we did
    > build this combination without dpdk but now we'll build it again with
    > dpdk.
    
    Signed-off-by: Kefu Chai <[email protected]>
    tchaikov committed May 8, 2024
    Configuration menu
    Copy the full SHA
    8f388df View commit details
    Browse the repository at this point in the history