Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove https from domain and default delegationNetwork to mainnet #459

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

ChaituVR
Copy link
Member

Fixes https://github.com/snapshot-labs/workflow/issues/253

How to test

// if (snapshot.utils.validateSchema(snapshot.schemas.space, space) !== true) {
    //   return Promise.reject('invalid space format');
    // }

src/helpers/actions.ts Outdated Show resolved Hide resolved
@ChaituVR ChaituVR merged commit adf8900 into master Oct 16, 2024
2 checks passed
@ChaituVR ChaituVR deleted the fix-domain-and-delegation-portal-network branch October 16, 2024 04:57
Comment on lines +12 to +13
...settings.delegationPortal,
delegationNetwork: settings.delegationPortal.delegationNetwork ?? '1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swapping these 2 lines would have allowed using just delegationNetwork: '1'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants