-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor settings setters; use snapshots for events #456
Conversation
formatting failed but running |
starknet/src/utils/types.cairo
Outdated
authenticators_to_add: NoUpdateArray::no_update(), | ||
authenticators_to_remove: NoUpdateArray::no_update(), | ||
voting_strategies_to_add: NoUpdateArray::no_update(), | ||
voting_strategies_metadata_URIs_to_add: array::ArrayTrait::new(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use NoUpdateArray::no_update()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it was a miss; it's because at first I wanted to have something visually different to remind me that NoUpdateString::no_update()
has not been implemented yet...
We can go with empty
for now but I think we'll need to change in the future because ""
is a valid metadata_uri and I'd be happier with something like No Update
as a string to indicate it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we can change to NoUpdateArray::no_update()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aye! will do
might be that |
set*
functionsupdate_settings
function, similarly to sx-evm.@
(snapshot) rather than values.Closes #427