Show actual version running on pods #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthapar
requested review from
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr204/vthapar/show-versions |
skitt
requested changes
Jul 10, 2023
There was a problem hiding this comment.
Just some typo fixes!
Some of our pods produce lots of logs, especially in circumstances where we need to diagnose a Submariner setup. I do still think that logging the version number will be helpful, and subctl should look there first to find out what version of a component is running. However it might be worth adding a --version flag to all components, and then have subctl exec the appropriate binary in each pod to extract the version information if it can’t get it from the logs.
|
|
||
| ## User Impact | ||
|
|
||
| * Users will need to modify any scripts or tooling that rely on current output of `show versions` or version log message |
There was a problem hiding this comment.
We should offer JSON output from subctl ;-). (Just a note, not requesting this here!)
dfarrell07
reviewed
Jul 10, 2023
dfarrell07
reviewed
Jul 10, 2023
|
Relevant: submariner-io/submariner#2552 |
tpantelis
approved these changes
Jul 19, 2023
sridhargaddam
approved these changes
Jul 19, 2023
|
@sridhargaddam @tpantelis Proposal has been changed since your approvals, so re-requesting review. |
skitt
approved these changes
Jul 25, 2023
|
Closing and re-opening to trigger CI. |
|
🤖 Closed branches: [z_pr204/vthapar/show-versions] |
|
🤖 Created branch: z_pr204/vthapar/show-versions |
sridhargaddam
approved these changes
Jul 25, 2023
|
Closing and re-opening to trigger CI. |
|
🤖 Closed branches: [z_pr204/vthapar/show-versions] |
This was referenced Aug 2, 2023
vthapar
added a commit
to vthapar/shipyard
that referenced
this pull request
Aug 2, 2023
Adds a `version` file to nettest image which can help determine version in-use for submariner-metrics-proxy pods Refer submariner-io/enhancements#204 Fixes submariner-io#1327 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/lighthouse
that referenced
this pull request
Aug 2, 2023
Adds `--version` flag to Lighthouse Agent and `--subm-version` flag to Lighthouse Coredns. CoreDNS already has `--version` which prints CoreDNS version, so we can't use the same flag for Lighthouse version. Refer submariner-io/enhancements#204 Fixes submariner-io#1333 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/submariner-operator
that referenced
this pull request
Aug 2, 2023
Refer submariner-io/enhancements#204 Fixes submariner-io#2751 Signed-off-by: Vishal Thapar <[email protected]>
This was referenced Aug 2, 2023
submariner-bot
pushed a commit
to submariner-io/submariner
that referenced
this pull request
Aug 2, 2023
* Adds `--version` flag to all submariner binaries. * Modifies version log msg to also show component name Refer submariner-io/enhancements#204 Fixes #2633 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/lighthouse
that referenced
this pull request
Aug 3, 2023
Adds `--version` flag to Lighthouse Agent and `--subm-version` flag to Lighthouse Coredns. CoreDNS already has `--version` which prints CoreDNS version, so we can't use the same flag for Lighthouse version. Refer submariner-io/enhancements#204 Fixes submariner-io#1333 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/lighthouse
that referenced
this pull request
Aug 3, 2023
Adds `--version` flag to Lighthouse Agent and `--subm-version` flag to Lighthouse Coredns. CoreDNS already has `--version` which prints CoreDNS version, so we can't use the same flag for Lighthouse version. Refer submariner-io/enhancements#204 Fixes submariner-io#1333 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/lighthouse
that referenced
this pull request
Aug 3, 2023
Adds `--version` flag to Lighthouse Agent and `--subm-version` flag to Lighthouse Coredns. CoreDNS already has `--version` which prints CoreDNS version, so we can't use the same flag for Lighthouse version. Refer submariner-io/enhancements#204 Fixes submariner-io#1333 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/lighthouse
that referenced
this pull request
Aug 4, 2023
Adds `--version` flag to Lighthouse Agent and `--subm-version` flag to Lighthouse Coredns. CoreDNS already has `--version` which prints CoreDNS version, so we can't use the same flag for Lighthouse version. Removed a log entry from metrics.go which didn't add much value so we can have version as first entry in log file. Refer submariner-io/enhancements#204 Fixes submariner-io#1333 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/submariner-operator
that referenced
this pull request
Aug 4, 2023
Refer submariner-io/enhancements#204 Fixes submariner-io#2751 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/submariner
that referenced
this pull request
Aug 4, 2023
* Adds `--version` flag to all submariner binaries. * Modifies version log msg to also show component name Refer submariner-io/enhancements#204 Fixes submariner-io#2633 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/submariner-operator
that referenced
this pull request
Aug 4, 2023
Refer submariner-io/enhancements#204 Fixes submariner-io#2751 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/lighthouse
that referenced
this pull request
Aug 7, 2023
Adds `--version` flag to Lighthouse Agent and `--subm-version` flag to Lighthouse Coredns. CoreDNS already has `--version` which prints CoreDNS version, so we can't use the same flag for Lighthouse version. Removed a log entry from metrics.go which didn't add much value so we can have version as first entry in log file. Refer submariner-io/enhancements#204 Fixes submariner-io#1333 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/lighthouse
that referenced
this pull request
Aug 7, 2023
Adds `--version` flag to Lighthouse Agent and `--subm-version` flag to Lighthouse Coredns. CoreDNS already has `--version` which prints CoreDNS version, so we can't use the same flag for Lighthouse version. Removed a log entry from metrics.go which didn't add much value so we can have version as first entry in log file. Refer submariner-io/enhancements#204 Fixes submariner-io#1333 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/lighthouse
that referenced
this pull request
Aug 7, 2023
Adds `--version` flag to Lighthouse Agent and `--subm-version` flag to Lighthouse Coredns. CoreDNS already has `--version` which prints CoreDNS version, so we can't use the same flag for Lighthouse version. Removed a log entry from metrics.go which didn't add much value so we can have version as first entry in log file. Refer submariner-io/enhancements#204 Fixes submariner-io#1333 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/submariner-operator
that referenced
this pull request
Aug 7, 2023
Refer submariner-io/enhancements#204 Fixes submariner-io#2751 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/submariner
that referenced
this pull request
Aug 7, 2023
* Adds `--version` flag to all submariner binaries. * Modifies version log msg to also show component name Refer submariner-io/enhancements#204 Fixes submariner-io#2633 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/submariner-operator
that referenced
this pull request
Aug 7, 2023
Refer submariner-io/enhancements#204 Fixes submariner-io#2751 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/submariner-operator
that referenced
this pull request
Aug 7, 2023
Refer submariner-io/enhancements#204 Fixes submariner-io#2751 Signed-off-by: Vishal Thapar <[email protected]>
tpantelis
pushed a commit
to submariner-io/submariner-operator
that referenced
this pull request
Aug 7, 2023
Refer submariner-io/enhancements#204 Fixes #2751 Signed-off-by: Vishal Thapar <[email protected]>
tpantelis
pushed a commit
to submariner-io/lighthouse
that referenced
this pull request
Aug 8, 2023
Adds `--version` flag to Lighthouse Agent and `--subm-version` flag to Lighthouse Coredns. CoreDNS already has `--version` which prints CoreDNS version, so we can't use the same flag for Lighthouse version. Removed a log entry from metrics.go which didn't add much value so we can have version as first entry in log file. Refer submariner-io/enhancements#204 Fixes #1333 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
added a commit
to vthapar/submariner
that referenced
this pull request
Aug 8, 2023
* Adds `--version` flag to all submariner binaries. * Modifies version log msg to also show component name Refer submariner-io/enhancements#204 Fixes submariner-io#2633 Signed-off-by: Vishal Thapar <[email protected]>
tpantelis
pushed a commit
to submariner-io/shipyard
that referenced
this pull request
Aug 8, 2023
Adds a `version` file to nettest image which can help determine version in-use for submariner-metrics-proxy pods Refer submariner-io/enhancements#204 Fixes #1327 Signed-off-by: Vishal Thapar <[email protected]>
tpantelis
pushed a commit
to submariner-io/submariner
that referenced
this pull request
Aug 8, 2023
* Adds `--version` flag to all submariner binaries. * Modifies version log msg to also show component name Refer submariner-io/enhancements#204 Fixes #2633 Signed-off-by: Vishal Thapar <[email protected]>
novad03
pushed a commit
to novad03/k8s-submariner
that referenced
this pull request
Nov 25, 2023
* Adds `--version` flag to all submariner binaries. * Modifies version log msg to also show component name Refer submariner-io/enhancements#204 Fixes #2633 Signed-off-by: Vishal Thapar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to enhance
show versionsto show actual version running on pods.Related issue #798