log submariner component's version on startup

[cyclinder]

#2548

[submariner-bot]

🤖 Created branch: z_pr2552/cyclinder/version
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

[cyclinder]

Thanks for all your comments! @nirs

All comments have been addressed, But It's failed to image build, I'm not familiar with build code, it seems now submariner doesn't support go build with -ldflags? I'm trying to build it in my local, and it works.

cyclinder  submariner   ( version)  ♥ 15:00  make bin/%/submariner-route-agent                                                                                      
docker network create  -d bridge kind
Error response from daemon: network with name kind already exists
make: [bin/%/submariner-route-agent] Error 1 (ignored)
./.dapper   -- make  bin/%/submariner-route-agent
[+] Building 0.2s (8/8) FINISHED                                                                                                                                                                     
 => [internal] load build definition from Dockerfile.dapper                                                                                                                                     0.0s
 => => transferring dockerfile: 44B                                                                                                                                                             0.0s
 => [internal] load .dockerignore                                                                                                                                                               0.0s
 => => transferring context: 2B                                                                                                                                                                 0.0s
 => [internal] load metadata for quay.io/submariner/shipyard-dapper-base:devel                                                                                                                  0.0s
 => [1/4] FROM quay.io/submariner/shipyard-dapper-base:devel                                                                                                                                    0.0s
 => CACHED [2/4] WORKDIR /go/src/github.com/submariner-io/submariner                                                                                                                            0.0s
 => CACHED [3/4] RUN git config --global --add safe.directory /go/src/github.com/submariner-io/submariner                                                                                       0.0s
 => CACHED [4/4] RUN git config --global --add safe.directory /go/src/github.com/submariner-io/submariner/ovn-kubernetes                                                                        0.0s
 => exporting to image                                                                                                                                                                          0.0s
 => => exporting layers                                                                                                                                                                         0.0s
 => => writing image sha256:73287c580d965569832571e6ff0b32c86237c0954bb5ea21ba25b282cf2e5db8                                                                                                    0.0s
 => => naming to docker.io/library/submariner:version                                                                                                                                           0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
Checking if Makefile.dapper is up to date
Checking if Dockerfile.dapper is up to date
GOARCH=bin/%/ \
LDFLAGS=-X github.com/submariner-io/submariner/pkg/version/version.gitCommitHash=a28429ee67f72047ce4e92efad8ec4eab5eed78f -X github.com/submariner-io/submariner/pkg/version/version.gitCommitDate=2023-06-24T14:52:48+08:00 \
/opt/shipyard/scripts/compile.sh bin/%/submariner-route-agent ./pkg/routeagent_driver
/bin/bash: line 1: github.com/submariner-io/submariner/pkg/version/version.gitCommitHash=a28429ee67f72047ce4e92efad8ec4eab5eed78f: No such file or directory
make: *** [Makefile:73: bin/%/submariner-route-agent] Error 127
make: *** [bin/%/submariner-route-agent] Error 2
cyclinder  submariner   ( version)  ♥ 15:00  LDFLAGS1="-X github.com/submariner-io/submariner/pkg/version/version.gitCommitHash=GIT_COMMIT_HASH -X github.com/submariner-io/submariner/pkg/version/version.gitCommitDate=GIT_COMMIT_DATE"
cyclinder  submariner   ( version)  ♥ 15:00  CGO_ENABLED=0 GOOS=linux ARCH=amd64 go build -trimpath  -ldflags "-s -w ${LDFLAGS1}" -o router  ./pkg/routeagent_driver
cyclinder  submariner   ( version)  ♥ 15:00  ls router                   
router
cyclinder  submariner   ( version)  ♥ 15:00  

I would be very grateful if you could help me.

[nirs]

GOARCH=bin/%/
LDFLAGS=-X github.com/submariner-io/submariner/pkg/version/version.gitCommitHash=a28429ee67f72047ce4e92efad8ec4eab5eed78f -X github.com/submariner-io/submariner/pkg/version/version.gitCommitDate=2023-06-24T14:52:48+08:00
/opt/shipyard/scripts/compile.sh bin/%/submariner-route-agent ./pkg/routeagent_driver
/bin/bash: line 1: github.com/submariner-io/submariner/pkg/version/version.gitCommitHash=a28429ee67f72047ce4e92efad8ec4eab5eed78f: No such file or directory

Because LDFLAGS= value was not quoted, we tried to execute:

github.com/submariner-io/submariner/pkg/version/version.gitCommitHash=a28429ee67f72047ce4e92efad8ec4eab5eed78f

[cyclinder]

Thanks again for your comments. I believe the CI can pass this time.

[nirs]

Looks good except the change in default version and unneeded export in the makefile.

[nirs]

Strange that LDFLAGS =-X github.com/submariner-io/submariner/pkg/version.Version= works but it will be easy to change such details later if needed.

[cyclinder]

Oh，I think it's nit here, it should be version rather than Version.

[cyclinder]

Thanks all @nirs @tpantelis

[submariner-bot]

🤖 Closed branches: [z_pr2552/cyclinder/version]

[dfarrell07]

Backported to 0.15: #2615
Doesn't backport cleanly to 0.14.