Template static properties + consistency check #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on two (interconnected) things:
We added support for all remaining template static properties. Currently, all templates are encoded into FO logic and then evaluated via the FOL evaluator. There are new methods to encode monotonicity (including the 'dual' case) and essentiality, as well as to encode that a property must be valid in a particular context.
We fully implemented the consistency checking. The check is now implicitly done whenever starting the inference workflow, as well as explicitly via a button. It now properly checks whether all IDs referenced in properties are valid, checks if dataset variables are valid, and checks all details regarding FOL and HCTL formulas (including context formulas of static properties).
Furthermore:
algorithms
module