Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template static properties + consistency check #49

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Conversation

ondrej33
Copy link
Member

This PR focuses on two (interconnected) things:

  1. We added support for all remaining template static properties. Currently, all templates are encoded into FO logic and then evaluated via the FOL evaluator. There are new methods to encode monotonicity (including the 'dual' case) and essentiality, as well as to encode that a property must be valid in a particular context.

  2. We fully implemented the consistency checking. The check is now implicitly done whenever starting the inference workflow, as well as explicitly via a button. It now properly checks whether all IDs referenced in properties are valid, checks if dataset variables are valid, and checks all details regarding FOL and HCTL formulas (including context formulas of static properties).

Furthermore:

  • we added a button to hide all automatically generated regulation properties
  • we extended the data with a few additional models for testing
  • we simplified how sketch data are sent from the editor to the analysis session (when starting a new analysis)
  • we moved methods for encoding dynamic properties into the algorithms module
  • we fixed a few issues in the evaluation of FOL formulas

@ondrej33 ondrej33 merged commit eeee21c into main Sep 17, 2024
1 of 2 checks passed
@ondrej33 ondrej33 deleted the dev-analysis-complete branch September 17, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant