Protection against memory spikes when downloading assets #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ababic
force-pushed
the
feature/max-asset-file-size
branch
3 times, most recently
from
d6d19dc
to
d4ac0c8
Compare
ababic
force-pushed
the
feature/max-asset-file-size
branch
4 times, most recently
from
4db908c
to
f45f957
Compare
… settings to restrict how large document and image files need to be in order to successfully download
… to model classes, and update image and document models to use the appropriate util methods
ababic
force-pushed
the
feature/max-asset-file-size
branch
from
f45f957
to
dc6f38a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites asset download functions to stream file contents into memory, instead of reading it all in one go.
It also adds the
BYNDER_MAX_DOCUMENT_FILE_SIZEandBYNDER_MAX_IMAGE_FILE_SIZEsettings, which provides a way for apps to place an upper boundary on the sizes of files they attempt to load into memory, reducing the likelihood of spikes during download. The default value of 5MB is quite conservative, but can be increased to fit the project setup (as outlined in the updated docs)