Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket32622 044 #1955

Open
wants to merge 5 commits into
base: maint-0.4.4
Choose a base branch
from

Conversation

nmathewson
Copy link
Contributor

No description provided.

Previously, we would only update this field when the error happened
during a read.

This will improves our reporting for our bootstrap status, and help
to address #32622.  The problem is not completely solved by this
patch, however: too many errors are still lumped into "MISC".
If our TLS connection fails for a "misc" reason, we don't need to
say that the reason is "misc" -- we can at least localize it to
the TLS module.

Part of a fix for #32622.
Now instead of saying "DONE, DONE" or "MISC, MISC" or "TLS_ERROR,
TLS_ERROR",  we can finally give a nice sensible "TLS_ERROR,
wrong version number" which should help debug a great deal.

Closes ticket 32622.
@coveralls
Copy link

coveralls commented Jun 26, 2020

Pull Request Test Coverage Report for Build 9222

  • 7 of 19 (36.84%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 64.169%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/mainloop/connection.c 0 1 0.0%
src/core/or/reasons.c 0 2 0.0%
src/lib/tls/tortls_openssl.c 2 6 33.33%
src/core/or/connection_or.c 5 10 50.0%
Files with Coverage Reduction New Missed Lines %
src/core/mainloop/connection.c 1 28.49%
Totals Coverage Status
Change from base Build 9204: -0.005%
Covered Lines: 50990
Relevant Lines: 79462

💛 - Coveralls

…hem.

Avoid using PRErrorCode in a header, since we try not to use NSPR
headers outside of the crypto layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants