Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket32622 044 #1955

Open
wants to merge 5 commits into
base: maint-0.4.4
Choose a base branch
from
Open

Ticket32622 044 #1955

wants to merge 5 commits into from

Commits on Jun 26, 2020

  1. Store errors from TLS write and handshake in the tls_error field. 

    Previously, we would only update this field when the error happened
during a read.

This will improves our reporting for our bootstrap status, and help
to address #32622.  The problem is not completely solved by this
patch, however: too many errors are still lumped into "MISC".
    @nmathewson
    nmathewson committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    d486c6c View commit details
    Browse the repository at this point in the history

  2. Add a TLS_ERROR bootstrap failure reason. 

    If our TLS connection fails for a "misc" reason, we don't need to
say that the reason is "misc" -- we can at least localize it to
the TLS module.

Part of a fix for #32622.
    @nmathewson
    nmathewson committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    e429ceb View commit details
    Browse the repository at this point in the history

  3. Carry TLS error strings forward to controller when reporting them. 

    Now instead of saying "DONE, DONE" or "MISC, MISC" or "TLS_ERROR,
TLS_ERROR",  we can finally give a nice sensible "TLS_ERROR,
wrong version number" which should help debug a great deal.

Closes ticket 32622.
    @nmathewson
    nmathewson committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    5127880 View commit details
    Browse the repository at this point in the history

  4. Changes file for #32622.

    @nmathewson
    nmathewson committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    010dfdf View commit details
    Browse the repository at this point in the history

  5. fixup! Carry TLS error strings forward to controller when reporting t… 

    …hem.

Avoid using PRErrorCode in a header, since we try not to use NSPR
headers outside of the crypto layer.
    @nmathewson
    nmathewson committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    87f19c2 View commit details
    Browse the repository at this point in the history