Move the routing context implementation to a separate method instead of failing the context within the constructor #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of failing the context within the constructor. Motivation: The implementation of routing context might fail the context within its constructor forcing the router to check the context status before routing the request. Changes: Create package private route method that performs the preliminary checks of the routing context and calls the routing context handler chain whenever the checks have passed
vietj
force-pushed
the
routing-context-route
branch
from
d124bd7
to
073d5d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The implementation of routing context might fail the context within its constructor forcing the router to check the context status before routing the request.
Changes:
Create package private route method that performs the preliminary checks of the routing context and calls the routing context handler chain whenever the checks have passed