-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conflation of identifier
: use class traceability:Identifier
#571
Comments
idenifier
: use class traceability:Identifier
identifier
: use class traceability:Identifier
This comment was marked as resolved.
This comment was marked as resolved.
Discussed on call, @mkhraisha to review. |
I believe the ask here is use
|
I didn't attend to this, will work on it soon. |
@mkhraisha, progress on this? There are also parts of this I should do, assigning myself as well. |
No!
|
Will take care of this issue soon.
use the Structured Value With Prefix system as laid out in #944 |
@mkhraisha on the next call can we discuss exactly what needs done on this, pls? |
Reading through this I'm not clear on what a property making use of PropertyID would look like. For example, on
What would an acceptable revision be? I can dig in further, but thought I'd ask in case it's obvious to someone else in this discussion. |
Would that be something like |
This would create |
This is the solution called "Structured Value With Prefix" at #944 (comment) |
@rhofvendahl your example repeats the conflation I've explained above. It takes a specific json key and maps it to a more generic RDF property. |
11 schemas use a URL containing
/identifier
multiple times:After #570 is fixed, this would probably mean they use the same
schema.org/identifier
URL multiple times.This probably means they conflate several different identifiers in one field.
I can see two cases, eg:
This conflates two different objects (the well and the gas extracted from it) into the same RDF prop
identifier
.NaturalGasProduct.UWI, NaturalGasProduct.HSCode
.NaturalGasProduct.facility.UWI, NaturalGasProduct.product.HSCode
identifier
, eg below two identifiers of entry and of manufacturer are conflated:assignedIdentifier
to two different objects (ImmediateDelivery vs Party): okentryNumber
andassignedIdentifier
to the same RDF propidentifier
assignedIdentifier
. The fact thatassignedIdentifierType
accommodates multiple agencies suggests that it should allow multiple identifiers.The cleanest way to solve all these cases is to use "structured identifiers", i.e. simple records that record the identifier value, but also its type ("propertyID").
And don't use specific sub-properties of identifier (which would be redundant with this identifier type).
Using schema.org, this can be expressed as follows in turtle (prefixes omitted for brevity).
The URLs also reflect some "URL policy" for making URLs of sub-objects rather than using blank nodes:
Better, you can define
traceability:Idenifier
as a subclass of:PropertyValue
specialized for expressing structured identifiers.You could also record extra data such as issuer, date issued, valid until, etc.
adms:Identifier
has similar stuff, and we used it in the euBusinessGraph ontology.The text was updated successfully, but these errors were encountered: