Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe and Waypoint Main Menu via Signpost Heading #366

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Describe and Waypoint Main Menu via Signpost Heading #366

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f708d7
Describe and waypoint Main Menu via signpost heading.
jkva Nov 26, 2021
cc41888
Use non-repeating "Main" label for navigation; use "Main Navigation" …
jkva Nov 29, 2021
4fa4bcc
Make the "Main Navigation" heading a child of the Navigation landmark.
jkva Nov 29, 2021
05d90bf
Reposition Skiplink and Home Anchor; rename Home Anchor to "Home".
jkva Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions client/components/App/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,25 +39,28 @@ const App = () => {
<Navbar
bg="light"
expand="lg"
aria-label="Main Menu"
aria-label="Main"
expanded={isNavbarExpanded}
onToggle={() => setIsNavbarExpanded(previous => !previous)}
>
<SkipLink />
<Navbar.Brand
className="logo"
as={Link}
to="/"
aria-current={location.pathname === '/'}
>
ARIA-AT
Home
</Navbar.Brand>
<SkipLink />
<h2 id="main-menu-heading" className="sr-only">
Main Navigation
</h2>
<Navbar.Toggle aria-controls="basic-navbar-nav" />
<Navbar.Collapse
id="basic-navbar-nav"
className="justify-content-end"
>
<ul>
<ul aria-labelledby="main-menu-heading">
<li>
<Nav.Link
as={Link}
Expand Down