-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe and Waypoint Main Menu via Signpost Heading #366
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkva Looks good. A few things:
- Can we change "Main Menu" to "Main Navigation"?
- Exchange
aria-labelledby
on thenav
foraria-label="Main"
, to avoid duplicate "navigation" announcements. - Move the
<h2>
inside thenav
. - If not already done, add
aria-labelledby
to the actual list wrapping the nav links, witharia-labelledby
referencing the new heading.
…as signpost heading text; describe navigation item list using signpost heading.
@jkva I noticed a couple of things here about the UI:
|
Hmm, neither of these things are proper. I've locally rebased this PR on #367, which overlaps with this (#366) PR in the sense that it also addresses navigation and styling. Once #367 gets merged I'll rebase #366 on |
This PR addresses the following item from PAC's "ARIA-AT App Screen Reader Accessibility Observations" document:
The "The navigation bar items ("Test Reports", " Test Queue", etc.) are not marked up inside an unordered list to convey their grouped nature to screen reader users" has previously been addressed.
Effective changes:
h2
element containing "Main Menu" was added to precede the main menunav
; andnav
is described by thish2
.