-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IRI resolution tests #13
Conversation
+1 from me. Call for consensus issued. |
(Minor tweak) If changes are still being made, one test per |
The new test is marked
|
f7c4ba3
to
72a6916
Compare
@afs Thanks, corrected to Why would you prefer one test per |
Same complexity - more entries in the manifest. It makes finding a failing URI easier. (Comparison of results should not depend on output order.) |
I don't mind either way; I just don't want to attach too much importance on the IRI resolution tests. By splitting them, it might give the appearance that several topics are failing, while it's just one topic. Note that each triple has a unique URI as subject, which facilitates finding failing URIs. Any other opinions on this? If several people agree, I happily split. |
Issue about the application of RDF 3986 "sec 5.2.3 merge paths." and "sec 5.2.4: Remove Dot Segments" sent to the email list. Not sure where this is best discussed. https://lists.w3.org/Archives/Public/public-rdf-tests/2015Oct/0022.html |
Adding one test per base/relative IRI would create over 300 new tests where there are just about 300 tests right now, so about doubling the number of tests. My usual metric is about one test per feature/normative statement with duplications in some cases. I would be fine with having one test per base, rather than per base/relative combination; that's what we'd need for SPARQL anyway. |
I see the case for alignment with SPARQL. Do I just number the tests then, i.e., |
Yes, that seems reasonable. In general, naming tests using a standard naming convention, and not trying too much to stick to existing naming seems like a good way to separate work done by this group from the original work. |
04802c4
to
fbb6da8
Compare
Alright, I split the tests. Made one exception though: I kept the miscellaneous tests (= not based on RFC3986) together; there are 3 |
@RubenVerborgh can we close this in favor of #30? |
Yes, we might revisit cases 3–6 at a later time. |
This pull request adds IRI resolution tests for Turtle and TriG, validating whether implementations correctly perform resolution as per RFC3986. Discussion on the mailing list.