Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IRI resolution tests #13

Closed
wants to merge 2 commits into from
Closed

Conversation

RubenVerborgh
Copy link
Member

This pull request adds IRI resolution tests for Turtle and TriG, validating whether implementations correctly perform resolution as per RFC3986. Discussion on the mailing list.

@gkellogg
Copy link
Member

+1 from me. Call for consensus issued.

@afs
Copy link
Contributor

afs commented Oct 19, 2015

(Minor tweak) If changes are still being made, one test per @base per language would be nice. Looking for a non-match is hard otherwise.

@afs
Copy link
Contributor

afs commented Oct 19, 2015

The new test is marked rdft:TestTurtlePositiveSyntax but should be rdft:TestTurtleEval

rdft:TestTurtlePositiveSyntax just requirtes the TTL file is parsable, no output checking.

@RubenVerborgh
Copy link
Member Author

@afs Thanks, corrected to TestTurtleEval and TestTrigEval.

Why would you prefer one test per @base? This would complexify the tests, it seems. What are the gains of doing so?

@afs
Copy link
Contributor

afs commented Oct 19, 2015

Same complexity - more entries in the manifest.

It makes finding a failing URI easier.

(Comparison of results should not depend on output order.)

@RubenVerborgh
Copy link
Member Author

I don't mind either way; I just don't want to attach too much importance on the IRI resolution tests. By splitting them, it might give the appearance that several topics are failing, while it's just one topic. Note that each triple has a unique URI as subject, which facilitates finding failing URIs.

Any other opinions on this? If several people agree, I happily split.

@afs
Copy link
Contributor

afs commented Oct 19, 2015

Issue about the application of RDF 3986 "sec 5.2.3 merge paths." and "sec 5.2.4: Remove Dot Segments" sent to the email list. Not sure where this is best discussed.

https://lists.w3.org/Archives/Public/public-rdf-tests/2015Oct/0022.html

@gkellogg
Copy link
Member

Adding one test per base/relative IRI would create over 300 new tests where there are just about 300 tests right now, so about doubling the number of tests. My usual metric is about one test per feature/normative statement with duplications in some cases. I would be fine with having one test per base, rather than per base/relative combination; that's what we'd need for SPARQL anyway.

@RubenVerborgh
Copy link
Member Author

I see the case for alignment with SPARQL. Do I just number the tests then, i.e., IRI-resolution-01 etc.?

@gkellogg
Copy link
Member

Yes, that seems reasonable. In general, naming tests using a standard naming convention, and not trying too much to stick to existing naming seems like a good way to separate work done by this group from the original work.

@RubenVerborgh
Copy link
Member Author

Alright, I split the tests. Made one exception though: I kept the miscellaneous tests (= not based on RFC3986) together; there are 3 @base statements in that file. Can change if required, but it seems to me that these tests belong together.

@gkellogg
Copy link
Member

gkellogg commented Jan 5, 2016

@RubenVerborgh can we close this in favor of #30?

@RubenVerborgh
Copy link
Member Author

Yes, we might revisit cases 3–6 at a later time.

@gkellogg gkellogg deleted the feature-iri-resolution branch January 9, 2016 18:10
@gkellogg gkellogg restored the feature-iri-resolution branch January 9, 2016 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants