Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update membership instead of remove + add chain #3805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivarnakken
Copy link
Member

Description

By preserving the membership, your position in the table will stay the same. Looks much better :)

Backend change: webkom/lego#3301

Result

Screen.Recording.2023-04-17.at.21.13.30.mov

any real user information.

Testing

  • I have thoroughly tested my changes.

What you see above. Your position is not changed.

@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review labels Apr 17, 2023
@ivarnakken ivarnakken self-assigned this Apr 17, 2023
@linear
Copy link

linear bot commented Apr 17, 2023

@ivarnakken ivarnakken changed the title Update membership instead of delete + create chain Update membership instead of remove + add chain Apr 17, 2023
Copy link
Contributor

@erlingfn erlingfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivarnakken ivarnakken added approved Pull requests that have been approved do-not-merge/hold Pull request is on hold (e.g. waiting for something else to be merged), and should not be merged and removed review-needed Pull requests that need review labels May 6, 2023
By preserving the memberhsip, your position in the table will stay the
same. Looks much better :)
@ivarnakken ivarnakken force-pushed the ivarnakken/aba-400-update-membership-instead-of branch from 7f23b49 to 162763d Compare January 18, 2024 13:41
@github-actions github-actions bot added the review-needed Pull requests that need review label Jan 18, 2024
@ivarnakken ivarnakken removed the review-needed Pull requests that need review label Jan 18, 2024
@eikhr
Copy link
Member

eikhr commented Sep 14, 2024

Why does this have "do-not-merge/hold"?

@ivarnakken
Copy link
Member Author

Why does this have "do-not-merge/hold"?

Because the backend is not fixed - had some issues with it. Wanted to change how memberships are created and used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved do-not-merge/hold Pull request is on hold (e.g. waiting for something else to be merged), and should not be merged enhancement Pull requests that make enhancements, instead of just purely new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants