Create a membership history when updating a membership #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
new-feature
1 task
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3301 +/- ##
==========================================
- Coverage 88.32% 88.30% -0.02%
==========================================
Files 661 661
Lines 20882 20893 +11
==========================================
+ Hits 18444 18450 +6
- Misses 2438 2443 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ivarnakken
added
testing-needed
LudvigHz
requested changes
Apr 17, 2023
| @@ -1,10 +1,16 @@ | |||
| from datetime import datetime | |||
There was a problem hiding this comment.
For consistency, use django.utils.timzone
Comment on lines
+48
to
+50
| start_date = datetime.strptime( | ||
| request.data["membership"]["created_at"], "%Y-%m-%dT%H:%M:%S.%fZ" | ||
| ) |
There was a problem hiding this comment.
Do serializer.is_valid() and use the serialized value in the create below and you can throw away this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend change: webkom/lego-webapp#3805
Tested manually that the creation of membership history works, but I'll write up a quick test for it soon.
Related to ABA-400