Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign repo list and include last pipeline #4386

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Redesign repo list and include last pipeline #4386

wants to merge 14 commits into from

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Nov 16, 2024

Supersedes: #2552

  • Use the same list for Repos/OrgRepos
  • Show the last four visited Repos
  • List all pipelines sorted by last pipeline creation

I tried out many variants of what information should be displayed in the repo list with different layouts and decided on the absolute minimum. Everything else seemed kind of overloaded and cluttered (especially as it has to work consistently on mobile). However, if you have any ideas, please let me know, but I would like to keep this PR small and focus on the repo list for now.

Repo list (desktop):

image

Repo list (mobile):

OrgRepo list (mobile):

@xoxys xoxys marked this pull request as draft November 16, 2024 14:40
@anbraten anbraten added ui frontend related enhancement improve existing features labels Nov 17, 2024
@xoxys xoxys requested a review from a team November 17, 2024 19:48
@xoxys xoxys marked this pull request as ready for review November 17, 2024 19:48
@anbraten
Copy link
Member

I would suggest to place the status icon in front of the last pipeline message to group all info that belongs to the pipeline. The time feels a bit far away on the desktop screen, however I've no nice idea were to place it instead. To avoid two icons we could remove the pipeline type icon (push, pr, ...).

Some similar UIs I've found:

image

image

https://v0.dev/chat/fWkCn1IFMjk?b=b_jUv2KjQbRRj

image

web/src/lib/api/types/repo.ts Outdated Show resolved Hide resolved
<span class="ml-auto">
<Badge
v-if="repo.visibility === RepoVisibility.Public"
:label="$t('repo.settings.general.visibility.public.public')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bring those translations a bit to the top level so sth like: visibility.public.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean. I have just used the existing translation from en.json and not added a new one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. You are using repo.settings.general.visibility.public.public which was for the settings page as you can see in the name. As duplicating such entries makes no sense IMO, I started to move things like repo.settings.general.visibility.public.public to a rather flat property like visibility.public away from the place it's used to rather match just the content.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok got it 👍 will take care

web/src/store/repos.ts Show resolved Hide resolved
web/src/views/Repos.vue Outdated Show resolved Hide resolved
@anbraten anbraten mentioned this pull request Nov 17, 2024
12 tasks
@anbraten anbraten changed the title Improve repo list Redesign repo list and include last pipeline Nov 17, 2024
@xoxys
Copy link
Member Author

xoxys commented Nov 17, 2024

I would suggest to place the status icon in front of the last pipeline message to group all info that belongs to the pipeline. The time feels a bit far away on the desktop screen, however I've no nice idea were to place it instead. To avoid two icons we could remove the pipeline type icon (push, pr, ...).

Did some rework. What do you think about this approach:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features ui frontend related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants