-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign repo list and include last pipeline #4386
base: main
Are you sure you want to change the base?
Conversation
I would suggest to place the status icon in front of the last pipeline message to group all info that belongs to the pipeline. The time feels a bit far away on the desktop screen, however I've no nice idea were to place it instead. To avoid two icons we could remove the pipeline type icon (push, pr, ...). Some similar UIs I've found: |
<span class="ml-auto"> | ||
<Badge | ||
v-if="repo.visibility === RepoVisibility.Public" | ||
:label="$t('repo.settings.general.visibility.public.public')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you bring those translations a bit to the top level so sth like: visibility.public
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean. I have just used the existing translation from en.json
and not added a new one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. You are using repo.settings.general.visibility.public.public
which was for the settings page as you can see in the name. As duplicating such entries makes no sense IMO, I started to move things like repo.settings.general.visibility.public.public
to a rather flat property like visibility.public
away from the place it's used to rather match just the content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok got it 👍 will take care
Did some rework. What do you think about this approach: |
Supersedes: #2552
I tried out many variants of what information should be displayed in the repo list with different layouts and decided on the absolute minimum. Everything else seemed kind of overloaded and cluttered (especially as it has to work consistently on mobile). However, if you have any ideas, please let me know, but I would like to keep this PR small and focus on the repo list for now.
Repo list (desktop):
Repo list (mobile):
OrgRepo list (mobile):