Settings: improved visibility of text and buttons #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you present before/after screenshots? Also, I'm not sure which component is the |
|
Update the description with old and new images... |
|
OK. Text definitely feels a lot better. The dark grey slider background might be overdoing it a bit; is there somewhere a bit in between worth trying? |
|
Maybe, but overall this is a definite improvement. |
I think the tab headings should also be in dark colour as it will be a good user experience |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Improves text and button visibility in settings page as reported in #1357
Screenshots?
Old:
New:
You have tested this PR on: