Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xacro and controllers runtime test #64

Merged
merged 23 commits into from
Sep 1, 2023
Merged

Xacro and controllers runtime test #64

merged 23 commits into from
Sep 1, 2023

Conversation

delihus
Copy link
Contributor

@delihus delihus commented Aug 21, 2023

bump::patch

@delihus
Added description xacro test
de03d7e 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
fixed deps
5a711fb 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
moved tests to rosbot_controller
5c04f83 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
description update
39077f1 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
ament_python build
f9679a4 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
changed build type for rosbot_bringup to ament_python
01ee8bc 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
Test ros2_controllers
50557f1 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
Added controllers test
a663a1b 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus delihus marked this pull request as draft August 21, 2023 10:44
@delihus
added dependencies
f8aafc7 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
fix dependencies
ddf6173 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
test ci
4b11c16 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
test ci
76c6a99 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
Moved xacro tests to rosbot_description
83f3cc5 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
Merge branch 'test-description' into test-bringup
fa5d728
@delihus
moved test to rosbot_controller
de19a38
@delihus
moved xacro test to rosbot_controller
6342097 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
added mecanum test
f34a0fa 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
fixed dependencies
55d87de 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus
changed timeouts to 10s
68f957d 
Signed-off-by: Jakub Delicat <[email protected]>
@delihus delihus changed the title Test bringup Xacro and controllers runtime test Aug 25, 2023
@delihus delihus marked this pull request as ready for review August 25, 2023 09:59
macstepien
macstepien requested changes Aug 31, 2023
View reviewed changes
rosbot_bringup/resource/rosbot_bringup Outdated Show resolved Hide resolved
rosbot_bringup/setup.py Outdated Show resolved Hide resolved
rosbot_description/setup.py Outdated Show resolved Hide resolved
rosbot_controller/test/controllers_test_node.py Outdated Show resolved Hide resolved
rosbot_controller/test/controllers_test_node.py Outdated Show resolved Hide resolved
macstepien
macstepien requested changes Sep 1, 2023
View reviewed changes
rosbot_description/package.xml Outdated
Comment on lines 25 to 19
<build_type>ament_cmake</build_type>
<build_type>ament_python</build_type>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible I think that it will be better to use ament_cmake for description also

@delihus delihus merged commit 92729be into humble Sep 1, 2023
1 check passed
@delihus delihus deleted the test-bringup branch September 1, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macstepien macstepien macstepien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delihus @macstepien