fix(simple-action-server): info log instead of warn on cancel #4684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cancelling a goal is nominal behavior and therefore it should not log warning. Signed-off-by: Rein Appeldoorn <[email protected]>
reinzor
force-pushed
the
fix/nav2-util-simple-action-server
branch
from
0fc8075
to
b02eff7
Compare
|
@SteveMacenski can we backport this on Jazzy? |
mergify bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Cancelling a goal is nominal behavior and therefore it should not log warning. Signed-off-by: Rein Appeldoorn <[email protected]> (cherry picked from commit d4c3faa)
SteveMacenski
pushed a commit
that referenced
this pull request
Sep 23, 2024
…#4686) Cancelling a goal is nominal behavior and therefore it should not log warning. Signed-off-by: Rein Appeldoorn <[email protected]> (cherry picked from commit d4c3faa) Co-authored-by: Rein Appeldoorn <[email protected]>
|
Done |
|
Great! Thanks @SteveMacenski for all your hard work and quick responses! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancelling a goal is nominal behavior and therefore it should not log warning.