Upgrade to selectize.js 0.15.2 #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Although @selectize/selectize does have a (slightly different) index.d.ts, it doesn't seem to be well maintained and/or relevant to the code we've written
cpsievert
force-pushed
the
selectize-v0.15.2
branch
from
43999be
to
627e2ff
Compare
cpsievert
force-pushed
the
selectize-v0.15.2
branch
from
5936b95
to
879fe7b
Compare
|
This might be addressed by this PR already, but I just noticed that select inputs add margin bottom on the 
Do you think it'd be possible to move that margin higher up in the component tree so that we could more easily disable it in a gap-spacing context (in bslib)? |
gadenbuie
reviewed
Aug 24, 2023
Co-authored-by: Garrick Aden-Buie <[email protected]>
Margin bottom is already provided on the shiny-input-container.
|
Great point @gadenbuie, addressed in b3d3298 I'm guessing that rule was there before |
gadenbuie
reviewed
Aug 25, 2023
cpsievert
commented
Aug 28, 2023
This was referenced Sep 7, 2023
cpsievert
added a commit
that referenced
this pull request
Sep 14, 2023
cpsievert
added a commit
that referenced
this pull request
Sep 14, 2023
This was referenced Oct 2, 2023
Closed
This was referenced Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3868
Closes #3839
Closes #3700
Closes #2957
(Will close) posit-dev/py-shiny#655